Skip to content

Conversation

@nyqykk
Copy link
Member

@nyqykk nyqykk commented Oct 25, 2024

Summary

vmok uses global by default.

When users use a external pkg like '@xxx', this will be transform to

var xxx = @xxx

which will cause syntax Error because there's no quotation marks. So set to global to avoid this

Related Links

close: #330

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 25, 2024

CodSpeed Performance Report

Merging #331 will not alter performance

Comparing fix/mf-external-type (828abcd) with main (3a68db0)

Summary

✅ 5 untouched benchmarks

@nyqykk nyqykk enabled auto-merge (squash) October 28, 2024 03:48
@nyqykk nyqykk merged commit caf5d69 into main Oct 28, 2024
19 checks passed
@nyqykk nyqykk deleted the fix/mf-external-type branch October 28, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot build if import package name include '@'

4 participants